brace tables with typst:no-figure and typst:text attributes #10563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79087f7 to
cc6d13e
Compare
The combination of jgm#9648 Typst property output and jgm#9778 `typst:no-figure` can cause fonts to spill out of tables. This is because setting Typst text properties across a table requires `#set text(...)` outside the table, and previously we were relying on the figure to provide a scope. This adds an extra `#[...]` when the table has class `typst:no-figure` and also has `typst:text:*` attributes.
cc6d13e to
271a4cb
Compare
|
This looks good. But instead of why not Isn't this a bit cleaner? |
for a more succinct output in code mode instead of content mode
|
Sure! The rest of the output uses content mode as a reasonable convention, but I'm a big fan of code mode in Typst. Done. P.S. I still think Haskell must have an abstraction to make the repeated logic of checking for empty lists in every function simpler? |
gordonwoodhull
added a commit
to quarto-dev/quarto-cli
that referenced
this pull request
Apr 8, 2025
because jgm/pandoc#10563 is merged closes #11093 continuing #11113 which contains a good end-to-end test
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
The combination of jgm#9648 Typst property output and jgm#9778 `typst:no-figure` can cause fonts to spill out of tables. This is because setting Typst text properties across a table requires `set text(...)` outside the table, and previously we were relying on the figure to provide a scope. This adds an extra `#{...}` when the table has class `typst:no-figure` and also has `typst:text:*` attributes.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
The combination of jgm#9648 Typst property output and jgm#9778 `typst:no-figure` can cause fonts to spill out of tables. This is because setting Typst text properties across a table requires `set text(...)` outside the table, and previously we were relying on the figure to provide a scope. This adds an extra `#{...}` when the table has class `typst:no-figure` and also has `typst:text:*` attributes.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
The combination of jgm#9648 Typst property output and jgm#9778 `typst:no-figure` can cause fonts to spill out of tables. This is because setting Typst text properties across a table requires `set text(...)` outside the table, and previously we were relying on the figure to provide a scope. This adds an extra `#{...}` when the table has class `typst:no-figure` and also has `typst:text:*` attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of #9648
typst:text:*property output and #9778typst:no-figurecan cause fonts, text sizes, etc. to spill out of tables in Typst output.This is because setting Typst text properties across a table requires
#set text(...)outside the table, and previously we were relying on the figure to provide a scope.Example:
produces
This PR provides the minimal fix, only adding an extra
#[...]when the table has classtypst:no-figureand also hastypst:text:*attributes.We work around this bug in Quarto in quarto-dev/quarto-cli#11113, but it would be better to have the fix in Pandoc because it could affect other users of these features.
Ref quarto-dev/quarto-cli#11093
@cscheid