Split off pandoc-cli and pandoc-server #8309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely like the Lua part, it ensures a much cleaner separation! The only comments I have are about Looks really good to me. |
ea04290 to
65af167
Compare
|
I've merged the Lua changes into master, so this PR now only contains the splitting off of pandoc-cli and pandoc-server. One issue to consider is whether the pandoc man page (or perhaps a symlink to it) should go in pandoc-cli. Maybe the pandoc-server man page should go there too? But then, there's also a case to be made for including teh pandoc-server man page in pandoc-server. |
This also removes the unnecessary Setup.hs from pandoc. Cabal does not need this with build-type 'simple'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm putting this up for comment @tarleb.
If you like the Lua changes, we could merge this part separately before deciding on the package-splitting.