Relax upper bound for hslua, allow hslua-2.2. #7929
Conversation
|
Lua 5.4 would be used by default after this is merged. Packagers may still include Lua 5.3 instead by building pandoc with |
This change allows to use pandoc with Lua 5.4.
|
Adding more info about the Lua 5.3 / Lua 5.4 switch: It should be unnoticeable to script authors, incompatible changes are negligible IMHO. An argument against merging this: allowing both 5.3 and 5.4 could lead to confusion, as the pandoc version would not correspond to a specific Lua version. This is already the case, but to a lesser extend: e.g., Lua 5.3.3, shipped in Ubuntu Docker images, behaves slightly different in rare edge cases than the default Lua 5.3.6. Most major distributions already ship Lua 5.4 packages, with the exception of Ubuntu LTS. However, the next LTS release, to be release Apr. 21, will include Lua 5.4.4, same as the version shipping with hslua. So if we are ok with breaking Ubuntu LTS builds for 2 months, then we could just require hslua-2.2 instead of allowing both hslua-2.1 and hslua-2.2. |
|
If the differences btw 5.3 and 5.4 are minor, then I think this is okay. I'd rather avoid breaking Ubuntu LTS builds. Maybe add an issue as a reminder to tighten this constraint in two months? |
This will help us determine which version of Lua pandoc is compiled against. See #7929.
This change allows to use pandoc with Lua 5.4.