8000 address further error-prone warnings by lsf37 · Pull Request #699 · jflex-de/jflex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

address further error-prone warnings #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2020
Merged

address further error-prone warnings #699

merged 3 commits into from
Jan 3, 2020

Conversation

lsf37
Copy link
Member
@lsf37 lsf37 commented Jan 2, 2020

The charset for skeletons and graphviz dot files is UTF-8 (docs updated), for spec input/output files, Options.enconding.

lsf37 added 2 commits January 2, 2020 13:13
@lsf37
address another set of error-prone warnings
c6bfaa6
@lsf37
Address further error-prone warnings.
1d46401 
Mostly:
 * make final where possible
 * avoid implicit use of platform default charset (also fixes #470).

The charset for skeletons and graphviz dot files is UTF-8 (docs updated), for
spec input/output files, Options.enconding.
@lsf37 lsf37 requested a review from regisd January 2, 2020 10:22
@lsf37 lsf37 added the code quality Code health and clean-up label Jan 2, 2020
@lsf37 lsf37 added this to the 1.8.0 milestone Jan 3, 2020
@lsf37 lsf37 self-assigned this Jan 3, 2020
@lsf37 lsf37 merged commit 51fa835 into master Jan 3, 2020
@lsf37 lsf37 deleted the more-errorprone branch January 3, 2020 05:56
regisd pushed a commit that referenced this pull request Jan 3, 2020
@traviscibot
Pseudo-Merge 51fa835 address further error-prone warnings (#699)
2a9bddf 
commit 51fa835
Author:     Gerwin Klein <lsf@jflex.de>
AuthorDate: Fri Jan 3 13:56:43 2020 +0800
Commit:     GitHub <noreply@github.com>
CommitDate: Fri Jan 3 13:56:43 2020 +0800

    address further error-prone warnings (#699)

     * make final where possible
     * avoid implicit use of platform default charset (also fixes #470)
     * Vector -> ArrayList
     * Stack -> Deque

    The charset for skeletons and graphviz dot files is UTF-8 (docs updated), for spec input/output files, Options.enconding.

Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisd regisd Awaiting requested review from regisd

Assignees

@lsf37 lsf37

Labels
code quality Code health and clean-up
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Use of default charset in LexScan
1 participant
@lsf37
0