8000 Fix more PMD violations by regisd · Pull Request #418 · jflex-de/jflex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix more PMD violations #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2018
Merged

Fix more PMD violations #418

merged 11 commits into from
Oct 7, 2018

Conversation

regisd
Copy link
Member
@regisd regisd commented Oct 7, 2018

No description provided.

@regisd regisd self-assigned this Oct 7, 2018
@regisd regisd added the code quality Code health and clean-up label Oct 7, 2018
@regisd regisd added this to the 1.7.1 milestone Oct 7, 2018
@regisd regisd changed the title Test assertions Fix more PMD violations Oct 7, 2018
@regisd regisd merged commit b4407a5 into jflex-de:master Oct 7, 2018
@regisd regisd deleted the test-assertions branch October 7, 2018 15:08
regisd pushed a commit that referenced this pull request Oct 7, 2018
@traviscibot
Update from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
828562a 
Initial commit b4407a5
Author: Régis Décamps <regisd@google.com>
Date:   Sun Oct 7 17:08:21 2018 +0200

    Fix more PMD violations (#418)

    * Replace assertTrue($message$, false) by fail($message$)
    * Replace $a$.equals($b$) by Objects.equals($a$, $b$)
    * Change lgtm.yml (lgtm stuck?)
@lsf37 lsf37 modified the milestones: 1.7.1, 1.8.0 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@regisd regisd

Labels
code quality Code health and clean-up
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@regisd @lsf37
0