10000 feat(cloud): Add support for custom cloud app URL configuration by adamshiervani · Pull Request #207 · jetkvm/kvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cloud): Add support for custom cloud app URL configuration #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2025
Merged

feat(cloud): Add support for custom cloud app URL configuration #207

merged 4 commits into from
Feb 28, 2025

Conversation

adamshiervani
Copy link
Contributor
@adamshiervani adamshiervani commented Feb 28, 2025 •
edited
Loading
  • Removes all environment variables building in device mode
  • Add Cloud app url to device config
  • Simplifies using alternative cloud providers
image

cc @timothystewart6

@adamshiervani adamshiervani requested a review from ym February 28, 2025 00:29
timothystewart6
timothystewart6 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor
@timothystewart6 timothystewart6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, it means the we'll no longer need build with variables!

@adamshiervani
feat(cloud): Add support for custom cloud app URL configuration
69a25ce 
- Extend CloudState and Config to include CloudAppURL
- Update RPC methods to handle both API and app URLs
- Modify cloud adoption and settings routes to support custom app URLs
- Remove hardcoded cloud app URL environment file
- Simplify cloud URL configuration in UI
@adamshiervani
fix(cloud): Improve cloud URL configuration and adoption flow
ba3834b 
- Update error handling in cloud URL configuration RPC method
- Modify cloud adoption route to support dynamic cloud URLs
- Remove hardcoded default cloud URLs in device access settings
- Refactor cloud adoption click handler to be more flexible
@adamshiervani
refactor(cloud): Simplify cloud URL configuration RPC method
c0c196e 
- Update rpcSetCloudUrl to return only an error
- Remove unnecessary boolean return value
- Improve error handling consistency
@adamshiervani adamshiervani merged commit e4bb4f2 into dev Feb 28, 2025
1 check passed
@adamshiervani adamshiervani deleted the feat/cloud-app-config branch February 28, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothystewart6 timothystewart6 timothystewart6 approved these changes

@ym ym Awaiting requested review from ym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamshiervani @timothystewart6
0