8000 v0.9.5 enhancements patch by jesselawson · Pull Request #11 · jesselawson/tasty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

v0.9.5 enhancements patch #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

v0.9.5 enhancements patch #11

wants to merge 4 commits into from

Conversation

jesselawson
Copy link
Owner
  • Fixes an issue caused by deserializing JSON response values into a Table from the toml crate.
  • Responses from test runs now use serde_json::Value semantics.
  • This is pre-work to support the CI/CD integration milestone (a way to export test results to JSON).

@jesselawson
use serde_json::Value instead of Table for response json.
26dcd98 
Fixes an issue caused by deserializing JSON response values into a `Table` from the `toml` crate. 
Responses from test runs now use `serde_json::Value` semantics.
This is pre-work to support the CI/CD integration milestone (a way to export test results 
to JSON).
jesselawson
jesselawson commented Mar 11, 2025
View reviewed changes
src/lib.rs Outdated
if let Ok(json_v) = serde_json::to_value(v) {
response_json.get(k) == Some(&json_v)
} else {
false
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will coerce the expectation to being "not met" in the event the serde_json conversion fails. This may not be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jesselawson
0