8000 Fixed Croatian translation. by mmestrovic · Pull Request #20 · jenssegers/date · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Croatian translation. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2014
Merged

Fixed Croatian translation. #20

merged 2 commits into from
Jun 30, 2014

Conversation

mmestrovic
Copy link
Contributor

Fixed pluralisation in Croatian language.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9a9741d on mmestrovic:master into 998b61a on jenssegers:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2c82f05 on mmestrovic:master into 998b61a on jenssegers:master.

@jenssegers
Copy link
Owner

What is the third option in the language lines? Currently, the fallback translator only supports 2 translations, one singular and one plural.

@mmestrovic
Copy link
Contributor Author

Croatian is a little bit complicated than English and other languages, so
i'll try to explain you on example:
1 hour - 1 sat
2 hours - 2 sata
3 hours - 3 sata
4 hours - 4 sata
5 hours - 5 sati..
etc.

For that reason, we need the third option (using only two parameters won't
work and Laravel will throw an exception).
P.S. Before i made pull request, i tried it, and everything works fine.

On Mon, Jun 30, 2014 at 12:26 PM, Jens Segers notifications@github.com
wrote:

What is the third option in the language lines?

—
Reply to this email directly or view it on GitHub
#20 (comment)
.

@jenssegers
Copy link
Owner

If you are using Laravel it will work, but not with the fallback translator for outside of Laravel projects. I will update the fallback translator to support multiple plural forms.

jenssegers added a commit that referenced this pull request Jun 30, 2014
@jenssegers
Merge pull request #20 from mmestrovic/master
9e72a37 
Fixed Croatian translation.
@jenssegers jenssegers merged commit 9e72a37 into jenssegers:master Jun 30, 2014
jenssegers added a commit that referenced this pull request Jun 30, 2014
@jenssegers
Updated fallback translator to support multiple plural forms, #20
b67a3b9
@mmestrovic
Copy link
Contributor Author

@Albert221 : Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmestrovic @coveralls @jenssegers
0