8000 [Jenkins-75341] Sort deprecated plugins in alphabetical order by MUCCHU · Pull Request #10358 · jenkinsci/jenkins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jenkins-75341] Sort deprecated plugins in alphabetical order #10358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Jenkins-75341] Sort deprecated plugins in alphabetical order #10358

wants to merge 2 commits into from
+5 −2

Conversation

MUCCHU
Copy link
@MUCCHU MUCCHU commented Mar 1, 2025 •
edited by krisstern
Loading

See JENKINS-75341.

Testing done

This change just sorts the plugins by their display name alphabetically; hence, no automated tests are required.

Before

before

After

afteer

Proposed changelog entries

  • Deprecated plugins are now sorted by their names.

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@krisstern

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Mar 1, 2025
@welcome Welcome
Copy link
welcome bot commented Mar 1, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@krisstern krisstern changed the title Fix for Jenkins-75341 | Deprecated plugins in sorted order [Jenkins-75341] Sort deprecated plugins in order Mar 1, 2025
@krisstern
Copy link
Member

Hi @MUCCHU where is the rest of the Submitter Checklist?

@MUCCHU
Copy link
Author
MUCCHU commented Mar 1, 2025

I removed those items since they were not applicable in this case, eg change of dependencies, deprecated annotations, APIs etc. Do I need to add them back?

@krisstern
Copy link
Member

Also, did you test locally? I am seeing the below issues in the logs:

07:36:00  [INFO] There are 2 errors reported by Checkstyle 10.21.3 with C:\Jenkins\agent\workspace\Core_jenkins_PR-10358/src/checkstyle/checkstyle-configuration.xml ruleset.
07:36:01  [ERROR] src\main\java\hudson\PluginManager.java:[104,1] (imports) CustomImportOrder: Wrong lexicographical order for 'java.util.LinkedHashMap' import. Should be before 'java.util.LinkedHashSet'.
07:36:01  [ERROR] src\main\java\hudson\PluginManager.java:[118,8] (imports) UnusedImports: Unused import - java.util.function.Function.

@krisstern
Copy link
Member

I removed those items since they were not applicable in this case, eg change of dependencies, deprecated annotations, APIs etc. Do I need to add them back?

Yes, please keep the Submitter Checklist intact as its original form and check off only relevant items

@MUCCHU
Copy link
Author
MUCCHU commented Mar 1, 2025

Thanks for the feedback, I have added the complete submitter checklist. I am really sorry for the failing tests earlier, I ran the tests locally and it was successful now.

@mawinter69
Copy link
Contributor

duplicate of #10346

@krisstern
Copy link
Member

Yes, we should close this

@MUCCHU
Copy link
Author
MUCCHU commented Mar 1, 2025

Thank you for pointing that out. I had no clue that someone else was working on it too as there was no status/assignment update on Jira. But I will close this now.

@MUCCHU MUCCHU closed this Mar 1, 2025
@daniel-beck daniel-beck mentioned this pull request Mar 1, 2025
Open
14 tasks
@daniel-beck
Copy link
Member

FWIW per #10346 (comment) I would prefer this one over the other.

@MUCCHU MUCCHU reopened this Mar 1, 2025
@MUCCHU
Copy link
Author
MUCCHU commented Mar 1, 2025

The tests run fine both locally and in the pipeline. But this exclamation mark remains. Do you have any suggestions on how to improve?
image

@krisstern
Copy link
Member

The tests run fine both locally and in the pipeline. But this exclamation mark remains. Do you have any suggestions on how to improve?

These look like they are transient and may go away if we re-run the tests on GitHub.

@krisstern krisstern changed the title [Jenkins-75341] Sort deprecated plugins in order [Jenkins-75341] Sort deprecated plugins in alphabetical order Mar 1, 2025
@MUCCHU
Copy link
Author
MUCCHU commented Mar 1, 2025

The tests run fine both locally and in the pipeline. But this exclamation mark remains. Do you have any suggestions on how to improve?

These look like they are transient and may go away if we re-run the tests on GitHub.

I really wish that's the case. I got the same result on build 2 btw.

@krisstern
Copy link
Member

I really wish that's the case. I got the same result on build 2 btw.

Please be more patient. I have just re-run the tests not long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawinter69 mawinter69 mawinter69 approved these changes

@daniel-beck daniel-beck Awaiting requested review from daniel-beck

@timja timja Awaiting requested review from timja

Assignees
No one assigned
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MUCCHU @krisstern @mawinter69 @daniel-beck
0