8000 Undo fixed header by ashmaroli · Pull Request #884 · jekyll/minima · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Undo fixed header #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Undo fixed header #884

merged 1 commit into from
Apr 4, 2025

Conversation

ashmaroli
Copy link
Member

Revert decision to have the .site-header fixed to top of viewport because of the following UX issue:

  • Fixed header creates confusion when user navigates to an anchor (especially when the anchor is not at start of the page) because the anchor (typically a heading element) gets hidden underneath the sticky-header.

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit dfaea3e into jekyll:master Apr 4, 2025
3 checks passed
jekyllbot added a commit that referenced this pull request Apr 4, 2025
@jekyllbot
Update history to reflect merge of #884 [ci skip]
145c814
@ashmaroli ashmaroli deleted the undo-fixed-header branch April 4, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmaroli @jekyllbot
0