fix: cache link tag rendering for performance #9840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @quanghuynguyen1902, do you have any benchmark results to demonstrate improvement in performance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
Cache the rendered value of
{% link %}tags to avoidredundant Liquid template parsing for the same link within a
rendering context.
Context
Resolves #9827
The
{% link %}tag currently re-renders its Liquid templateon every call, even when used multiple times with the same
path in the same context. This PR adds caching to store the
rendered value, reducing unnecessary template parsing and
improving build performance for sites with repeated link tags.