8000 Fix missing glob matching pattern support description in the documentation of the `include` and `exclude` configuration options by brlin-tw · Pull Request #9697 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing glob matching pattern support description in the documentation of the include and exclude configurat 8000 ion options #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brlin-tw
Copy link
Contributor
@brlin-tw brlin-tw commented Oct 11, 2024

This is a 🔦 documentation change.

Summary

This pull request adds a missing glob pattern support description in the documentation of the include and exclude site configuration options.

It appears that Regexp is also supported, but I am unable to use it at my end so it will not be addressed in this PR.

Context

Fixes #9696

< 8000 pre class="color-fg-muted ws-pre-wrap">…ation of the `include` and `exclude` configuration options Fixes jekyll#9696. Signed-off-by: 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>
@brlin-tw
Copy link
Contributor Author

The following tests failed on my end, but I failed to see how these tests are related to my change:

  • TestDocument#test_: a document with a date with timezone should have the expected date.
  • TestDocument#test_: a document with a date with timezone should return the expected date via Liquid.
  • TestFilters#test_: filters jsonify filter should convert drop to json.

@brlin-tw
Copy link
Contributor Author
brlin-tw commented Oct 11, 2024

For some reason, the unordered list markup broke the .description paragraph:

Screenshot

The corresponding Markdown template seems to be the following file:

https://github.com/jekyll/jekyll/blob/master/docs/_docs/configuration/options.md

but I am unable to figure out how to fix it so I will leave it here.

@ashmaroli
Copy link
Member

Thanks @brlin-tw
@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit 0c4a453 into jekyll:master Oct 20, 2024
3 checks passed
jekyllbot added a commit that referenced this pull request Oct 20, 2024
github-actions bot pushed a commit that referenced this pull request Oct 20, 2024
林博仁 Buo-ren Lin: Fix missing glob matching pattern support description in the documentation of the `include` and `exclude` configuration options (#9697)

Merge pull request 9697
@brlin-tw brlin-tw deleted the patch/improve-exclude-include-documentation branch October 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
0