8000 Backport add-csv-dependency from #9522 to Jekyll 3 by parkr · Pull Request #9616 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport add-csv-dependency from #9522 to Jekyll 3 #9616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

Backport add-csv-dependency from #9522 to Jekyll 3 #9616

merged 2 commits into from
Jun 13, 2024

Conversation

parkr
Copy link
Member
@parkr parkr commented Jun 13, 2024 •
edited
Loading

This is a 🙋 feature or enhancement.

Summary

This adds csv as a dependency in the gemspec.

I added a 3.10-stable branch since I think this should be a Jekyll 3.10 release (and go out to GitHub Pages).

Context

As of Ruby 3.3.0 I was seeing this warning print to the console when running jekyll serve:

/Users/username/.gem/ruby/3.3.0/gems/jekyll-4.3.3/lib/jekyll.rb:28: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of jekyll-4.3.3 to add csv into its gemspec.

Since this was a fairly simple fix, I figured I'd just throw a PR up for it. I wasn't sure what version to require as a dependency so I just used the latest major version of csv.

I didn't think there was any tests needed for this type of change but let me know if I'm wrong on that.

Notably if we wanted, this could be a conditional dependency on the ruby version wrapped with something like:

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')
 s.add_dependency("csv", "~> 3.0")
end

@parkr parkr requested a review from mattr- June 13, 2024 16:26
mattr-
mattr- reviewed Jun 13, 2024
View reviewed changes
Copy link
Member
@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are conflict markers still.

@parkr parkr mentioned this pull request Jun 13, 2024
Merged
mattr-
mattr- approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member
@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport. I agree on the 3.10-stable branch suggestion as well.

:shipit:

@parkr parkr force-pushed the 3.9-stable-backport-9522 branch from 7a6efb1 to 07a2a9d Compare June 13, 2024 16:30
@parkr
Copy link
Member Author
parkr commented Jun 13, 2024

@mattr- Are there any other dependencies we should add for Ruby 3? Maybe webrick?

@mattr-
Copy link
Member
mattr- commented Jun 13, 2024

That's the one only that comes to mind.

@parkr
Copy link
Member Author
parkr commented Jun 13, 2024

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 48c8dfa into 3.10-stable Jun 13, 2024
9 of 11 checks passed
@jekyllbot jekyllbot deleted the 3.9-stable-backport-9522 branch June 13, 2024 16:56
jekyllbot added a commit that referenced this pull request Jun 13, 2024
@jekyllbot
Update history to reflect merge of #9616 [ci skip]
ed79646
@parkr parkr mentioned this pull request Jun 13, 2024
Closed
2 tasks
@parkr
Copy link
Member Author
parkr commented Jun 13, 2024

Filed #9617 to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parkr @mattr- @jekyllbot @mmenanno
0