Update current Ruby version renders and macOS docs #9614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e79d06 to
9237426
Compare
|
Hello @monfresh, it would be better if you were to bump the JRuby version in a separate pull request. |
Merged
|
I have since extracted the JRuby version patch version bump in the CI matrix to its own, smaller PR. |
1b432ce to
7b5425e
Compare
|
@ashmaroli I just rebased and updated my PR. Please take a look. Also, since we are updating the minimum Ruby version to 3.1, should we also update the CI workflows matrix to remove Ruby 2.7, and add 3.1 instead? What about 3.2, do we want to include that as well? |
|
@monfresh Minimum version will remain Ruby 2.5.0 for v4.x. We'll bump the requirement when we bump the requirement in the gemspec for Jekyll 5. |
ashmaroli
reviewed
Sep 16, 2024
ashmaroli
approved these changes
Sep 16, 2024
This is a documentation change to update the current version of Ruby to the latest as of today: 3.3.5 As for the macOS docs, I updated the supported macOS versions to be in line with what Homebrew supports. I also removed `xz` from the prerequisites that need to be installed with Homebrew since it gets installed automatically when you install ruby-install.
|
Thanks @monfresh |
|
@jekyllbot: merge +doc |
ae79823 to
f4dfe8b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Moncef Belyamani: Update current Ruby version to 3.3.5 (#9614) This is a documentation change to update the current version of Ruby to the latest as of today: 3.3.5 As for the macOS docs, I updated the supported macOS versions to be in line with what Homebrew supports. I also removed `xz` from the prerequisites that need to be installed with Homebrew since it gets installed automatically when you install ruby-install. Co-authored-by: Moncef Belyamani <git@rubyonmac.dev>
github-actions bot
pushed a commit
to chrisfinazzo/jekyll
that referenced
this pull request
Sep 16, 2024
Moncef Belyamani: Update current Ruby version to 3.3.5 (jekyll#9614) This is a documentation change to update the current version of Ruby to the latest as of today: 3.3.5 As for the macOS docs, I updated the supported macOS versions to be in line with what Homebrew supports. I also removed `xz` from the prerequisites that need to be installed with Homebrew since it gets installed automatically when you install ruby-install. Co-authored-by: Moncef Belyamani <git@rubyonmac.dev>
ashmaroli
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is q
2BFF
ueued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🔦 documentation change.
Summary
This is a documentation change to update the current version of Ruby to the
latest as of today: 3.3.5
As for the macOS docs, I updated the supported macOS versions to be in line with what Homebrew supports. I also removed
xzfrom the prerequisites that need to be installed with Homebrew since it gets installed automatically when you install ruby-install.