Update convert-site-to-jekyll.md #9348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a parsing error created by the feed example.
parkr
reviewed
Aug 13, 2023
| @@ -426,7 +426,7 @@ layout: null | |||
| --- | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <rss version="2.0"> | |||
| <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> | |||
There was a problem hiding this comment.
Is this really an Atom file? Seems like RSS XML should work without making an Atom declaration.
There was a problem hiding this comment.
As https://validator.w3.org/feed/docs/warning/MissingAtomSelfLink.html explains:
According to the RSS Advisory Board's Best Practices Profile, identifying a feed's URL within the feed makes it more portable, self-contained, and easier to cache. For these reasons, a feed should contain an atom:link used for this purpose.
parkr
approved these changes
Aug 14, 2023
|
@jekyllbot: merge +docs |
jekyllbot
added a commit
that referenced
this pull request
Aug 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Jonas Jared Jacek: Update convert-site-to-jekyll.md (#9348) Merge pull request 9348
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
Fixed a parsing error created by the feed example. Also see https://validator.w3.org/feed/docs/warning/MissingAtomSelfLink.html.
Context