Rename sass partial created for new blank site #9257
Conversation
script/blank-site
Outdated
|
|
||
| print_label "Creating new BLANK site" | ||
| rm -Rf ./tmp/blank-site | ||
| bundle exec jekyll new tmp/blank-site --blank |
There was a problem hiding this comment.
I'm hesitant to duplicate script/default-site like this... I'm wondering if we can either reuse script/default-site for 99% of this script, or, better yet, use a Cucumber test for this.
There was a problem hiding this comment.
I think Cucumber is my favorite option here an alternative is to re-use default-site: #9259.
@parkr I have enhanced the Cucumber feature and removed duplicated shell script. |
| @@ -14,10 +14,15 @@ Feature: Create sites | |||
| And the test_blank/_sass directory should exist | |||
| And the test_blank/assets/css directory should exist | |||
| And the "test_blank/_layouts/default.html" file should exist | |||
| And the "test_blank/_sass/main.scss" file should exist | |||
| And the "test_blank/_sass/base.scss" file should exist | |||
There was a problem hiding this comment.
So to be clear, this test was failing with main.scss but doesn't with base.scss? If so, then let's ship this PR!
There was a problem hiding this comment.
Yes, that's correct.
dart-sass and therefore jekyll-sass-converter-3.0 doesn't allow css/foo.scss to import _sass/foo.scss.
|
@jekyllbot: merge +fix |
Ashwin Maroli: Rename sass partial created for new blank site (#9257) Merge pull request 9257
…blank site This backports 3a18480 to 4.3-stable
Summary
jekyll-sass-converter-3.0.0dropped support for importing sass partial named the same as the calling sass file.Therefore, rename the partial
_sass/main.scssto_sass/base.scss.Context
Resolves #9250