8000 Split `test/test_tags.rb` into multiple files by ashmaroli · Pull Request #9230 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Split test/test_tags.rb into multiple files #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2022
Merged

Split test/test_tags.rb into multiple files #9230

merged 2 commits into from
Dec 26, 2022

Conversation

ashmaroli
Copy link
Member

Summary

test/test_tags.rb is currently a monolith file testing all Liquid tags implemented in Jekyll core.
Split this file into individual files for each tag for better readability and maintainability.

  • with FN pattern test/test_tag_TAGNAME.rb.
  • Inherits from new TagUnitTest subclassed from JekyllUnitTest.

Context

#9188 (comment) by @mattr-.

@ashmaroli ashmaroli requested a review from mattr- December 26, 2022 13:25
mattr-
mattr- approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member
@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. :shipit:

@ashmaroli
Copy link
Member Author

Thanks Matt, I'll merge after the CI finishes running.

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit ee3576e into jekyll:master Dec 26, 2022
jekyllbot added a commit that referenced this pull request Dec 26, 2022
@jekyllbot
Update history to reflect merge of #9230 [ci skip]
0951a46
@ashmaroli ashmaroli deleted the split-test-tags branch December 26, 2022 14:16
github-actions bot pushed a commit that referenced this pull request Dec 26, 2022
@jekyllbot
Deploy docs from ee3576e
7b91663 
Ashwin Maroli: Split `test/test_tags.rb` into multiple files (#9230)

Merge pull request 9230
@jekyll jekyll locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmaroli @mattr- @jekyllbot
0