10000 Update CircleCI example by FelicianoTech · Pull Request #8829 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update CircleCI example #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2021
Merged

Update CircleCI example #8829

merged 1 commit into from
Sep 30, 2021

Conversation

FelicianoTech
Copy link
Contributor

The original purpose of my PR was to update the CircleCI images used in this example. We've deprecated the legacy Convenience images (the ones namespaced circleci/) and instead use the next-gen images (the ones namespaced cimg/). While I was in there though, I saw a bunch of other outdated CircleCI mentions or keys. So I updated all of it.

Quick summary:

  1. Updated image names to supported ones.
  2. Updated to v2.1 config.
  3. Removed references to CircleCI 1.0 nomenclature such as a "dependencies" step.
  4. Correct docs link.

@github-actions
Copy link
github-actions bot commented Sep 30, 2021 •
edited
Loading

@check-spelling-bot Report

Unrecognized words, please review:

  • cimg
Previously acknowledged words that are now absent eol
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:felicianotech/jekyll.git repository
on the update-cci-example branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/jekyll/jekyll/issues/comments/931340882" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u
If you see a bunch of garbage

If it relates to a ...

well-formed pattern

See if there's a pattern that would match it.

If not, try writing one and adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

binary-ish string

Please add a file path to the excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

mattr-
mattr- approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member
@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates to the documentation! 🎉

@mattr-
Copy link
Member
mattr- commented Sep 30, 2021

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 32e97a7 into jekyll:master Sep 30, 2021
jekyllbot added a commit that referenced this pull request Sep 30, 2021
@jekyllbot
Update history to reflect merge of #8829 [ci skip]
8d324d9
github-actions bot pushed a commit that referenced this pull request Sep 30, 2021
@jekyllbot
Deploy docs from 32e97a7
81e6672 
Ricardo N Feliciano: Update CircleCI example (#8829)

Merge pull request 8829
@jekyll jekyll locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelicianoTech @mattr- @jekyllbot
0