8000 Respect collections_dir config within include tag by ashmaroli · Pull Request #8756 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Respect collections_dir config within include tag #8756

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

Respect collections_dir config within include tag #8756

merged 1 commit into from
Aug 5, 2021

Conversation

ashmaroli
Copy link
Member
  • This is a 🐛 bug fix.
  • I've added tests
  • The test suite passes locally

Summary

Currently dependencies of documents within custom collections_dir were not being registered within .jekyll-metadata since the documents' correct absolute_path weren't being passed along. Consequently, changes to their include files does not trigger an incremental regeneration as expected.

This pull request fixes the problem.

Context

Possible backport-candidate to 3.9-stable ?

@ashmaroli ashmaroli added the fix label Aug 4, 2021
@DirtyF DirtyF requested review from a team, mattr- and parkr and removed request for a team August 4, 2021 12:59
DirtyF
DirtyF approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member
@DirtyF DirtyF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashwin, LGTM

mattr-
mattr- approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member
@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm also 👍 on a backport

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit aa9a416 into jekyll:master Aug 5, 2021
@jekyllbot jekyllbot added the bug label Aug 5, 2021
@ashmaroli ashmaroli deleted the include-tag-collections-tag branch August 5, 2021 15:10
jekyllbot added a commit that referenced this pull request Aug 5, 2021
@jekyllbot
Update history to reflect merge of #8756 [ci skip]
ca2f106
github-actions bot pushed a commit that referenced this pull request Aug 5, 2021
@jekyllbot
Deploy docs from aa9a416
b4b85a3 
Ashwin Maroli: Respect collections_dir config within include tag (#8756)

Merge pull request 8756
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Aug 29, 2021
@ashmaroli
Backport jekyll#8756 for v4.2.x
7bfba8e 
Respect collections_dir config within include tag
This backports aa9a416 to 4.2-stable
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Aug 30, 2021
@ashmaroli
Backport jekyll#8756 to 3.9-stable
5ab445a 
Respect collections_dir config within include tag
This backports and adapts aa9a416 and 1aea158 to 3.9-stable
parkr added a commit that referenced this pull request Aug 30, 2021
@parkr
Merge pull request #8795 from ashmaroli/3.9-stable-backport-8756
0f46edd 
Backport #8756 to 3.9-stable
ashmaroli added a commit that referenced this pull request Sep 16, 2021
@ashmaroli
Backport #8756 for v4.2.x: Respect collections_dir config within incl…
55a39dd 
…ude tag (#8794)

Respect collections_dir config within include tag
This backports aa9a416 and 1aea158 to 4.2-stable
@jekyll jekyll locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattr- mattr- mattr- approved these changes

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr Awaiting requested review from parkr

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @mattr- @DirtyF @jekyllbot
0