-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Step By Step Instructions Review #8399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n page - Update instruction text - Change content for consistency and clarity - Add note info classes where appropriate - Simplify the content
- For setup, add info about livereload option. - For liquid, edit content for clarity and better tutorial flow
@DirtyF draft request for changes to tutorials section. I'll undraft when all topics are ready for review. |
DirtyF
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the review 🙏
- Refined content on the front matter page and added a Note - Updated flow and content on layouts page
Nope. The monospace gemfile *should* be used when referring directly to the
file in the file system. The regular font should be used to refer
inderectly to the gemfile.
For example:
"Open the `Gemfile` in Notepad."
"The Gemfile is used to define parameters for blah"
In this case, you're right, we should be using the same formatting for all references. Thank you for pointing this out!
…On Sun., Nov. 15, 2020, 4:18 p.m. antonvasilev52, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/_docs/ruby-101.md
<#8399 (comment)>:
> [jekyll-feed](https://github.com/jekyll/jekyll-feed),
[jekyll-seo-tag](https://github.com/jekyll/jekyll-seo-tag) and
[jekyll-archives](https://github.com/jekyll/jekyll-archives).
## Gemfile
-A `Gemfile` is a list of gems required for your site. For a simple Jekyll site it might look something like this:
+A `Gemfile` is a list of gems used by your site. Every Jekyll site has a Gemfile in the main folder.
In this chapter, does the use of different formatting (monospace "Gemfile"
vs plain text "Gemfile") implies different meanings of this word?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8399 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHH4EFRPVEYIKNIGPDSWVHDSQBASNANCNFSM4RQM43YQ>
.
|
Let's publish this. @jekyll: merge +docs |
jekyllbot
added a commit
that referenced
this pull request
Jan 19, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
Shannon Kularathna: Step By Step Instructions Review (#8399) Merge pull request 8399
github-actions bot
pushed a commit
to chauncey-garrett/jekyll
that referenced
this pull request
Jan 19, 2021
jekyllbot: Update history to reflect merge of jekyll#8399 [ci skip]
github-actions bot
pushed a commit
to X-EcutiOnner/jekyll
that referenced
this pull request
Jan 19, 2021
jekyllbot: Update history to reflect merge of jekyll#8399 [ci skip]
github-actions bot
pushed a commit
to patilswapnilv/jekyll
that referenced
this pull request
Jan 19, 2021
jekyllbot: Update history to reflect merge of jekyll#8399 [ci skip]
github-actions bot
pushed a commit
to tigefa4u/jekyll
that referenced
this pull request
Jan 19, 2021
jekyllbot: Update history to reflect merge of jekyll#8399 [ci skip]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🔦 documentation change.
Summary
Reworking the step-by-step documentation for clarity, flow, and accuracy.