8000 Docs: Include version badge for latest features by jekyllbot · Pull Request #6574 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docs: Include version badge for latest features #6574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2017

Conversation

jekyllbot
Copy link
Contributor
@jekyllbot jekyllbot commented Nov 23, 2017

PR automatically created for @DirtyF.

Docs: Include version badge for latest features

Fix #6568

Example:

docs-version-badge

This has to be done manually for each new feature of the current or upcoming minor version.
We could also tag the features from the previous minor version.

Ideally a user could browse the documentation of a specific version without having to install jekyll-docs gem.

@DirtyF DirtyF changed the title Docs: Include version badge for latest features Fix #6568 Docs: Include version badge for latest features Nov 23, 2017
@DirtyF DirtyF requested a review from a team November 23, 2017 19:50
@DirtyF DirtyF added this to the v3.7.0 milestone Nov 23, 2017
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a class or two for pre-release callouts in the CSS (or we did). This looks great.

8000
@ghost
Copy link
ghost commented Nov 24, 2017

maybe vertically center the badge?

@DirtyF
Copy link
Member
DirtyF commented Nov 24, 2017

@parkr Correct, and I made sure we can use a version badge in any type of note:

version-badges

@pup The badge is now vertically aligned 😸

@DirtyF
Copy link
Member
DirtyF commented Nov 24, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 46b2501 into master Nov 24, 2017
@jekyllbot jekyllbot deleted the pull/docs-version-badge branch November 24, 2017 08:43
jekyllbot added a commit that referenced this pull request Nov 24, 2017
@ashmaroli
Copy link
Member

Nicely done @DirtyF 👏

DirtyF pushed a commit that referenced this pull request Dec 7, 2017
DirtyF pushed a commit that referenced this pull request Dec 7, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0