8000 Add json extension to list of directory indices by adborden · Pull Request #6550 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add json extension to list of directory indices #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2017
Merged

Add json extension to list of directory indices #6550

merged 3 commits into from
Nov 13, 2017

Conversation

adborden
Copy link
Contributor

Fixes #6348

@adborden adborden mentioned this pull request Nov 13, 2017
Closed
@pathawks
Copy link
Member

Now Rubocop says webrick_opts has too many lines. 🙃

@ashmaroli
Copy link
Member
ashmaroli commented Nov 13, 2017 •
edited
Loading

one way out is to move the entire array to a class constant or a new private method if that's better..
the other obvious way is to have two files per line.. 😄

            :DirectoryIndex     => %w(
              index.htm index.html
              index.rhtml index.cgi
              index.xml index.json
            ),

@pathawks
Copy link
Member

move the entire array to a class constant

✅:+1:

parkr
parkr approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on content – I'll let Rubocop dictate the style. 😄

adborden and others added 2 commits November 13, 2017 12:51
@adborden
Move directory index array to class constant
39ebb6b 
Rubocop says webrick_opts has too many lines, this reduces the line count for
the method.
@DirtyF
Merge branch 'master' into feature/json-directory-index
17a73ab
@DirtyF
Copy link
Member
DirtyF commented Nov 13, 2017

@adborden Thanks for this excellent first contrib! ❤️

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 707a8c7 into jekyll:master Nov 13, 2017
jekyllbot added a commit that referenced this pull request Nov 13, 2017
@jekyllbot
Update history to reflect merge of #6550 [ci skip]
621df9d
@DirtyF DirtyF added this to the v3.7.0 milestone Nov 13, 2017
@adborden adborden deleted the feature/json-directory-index branch November 13, 2017 22:13
@parkr
Copy link
Member
parkr commented Nov 13, 2017

Woohoo! Well done ✨

@parkr
Copy link
Member
parkr commented Nov 16, 2017

@adborden This has shipped on GitHub Pages and will roll out to 100% of sites over the next few hours.

@adborden
Copy link
Contributor Author
adborden commented Nov 17, 2017 via email

DirtyF pushed a commit that referenced this pull request Dec 7, 2017
@adborden @DirtyF
Add json extension to list of directory indices (#6550)
32d1b43 
Merge pull request 6550
DirtyF pushed a commit that referenced this pull request Dec 7, 2017
@jekyllbot @DirtyF
Update history to reflect merge of #6550 [ci skip]
c2ee73e
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

Support index.json in DirectoryIndex
6 participants
@adborden @pathawks @ashmaroli @DirtyF @parkr @jekyllbot
0