8000 Use Kernel#Array instead of explicit Array check by ashmaroli · Pull Request #6525 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use Kernel#Array instead of explicit Array check #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2017
Merged

Use Kernel#Array instead of explicit Array check #6525

merged 1 commit into from
Nov 6, 2017

Conversation

ashmaroli
Copy link
Member

Ref: bbatsov/ruby-style-guide
I don't think there's a cop for this yet.

Also, I guess its better handling such lines one-at-a-time..

@DirtyF DirtyF added the internal label Nov 6, 2017
@pathawks
Copy link
Member
pathawks commented Nov 6, 2017

A coP for this world be nice. Is there an open Rubocop issue to add this?

@ashmaroli
Copy link
Member Author

Is there an open Rubocop issue to add this?

None that I could pin-point on

@DirtyF
Copy link
Member
DirtyF commented Nov 6, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7690fcb into jekyll:master Nov 6, 2017
jekyllbot added a commit that referenced this pull request Nov 6, 2017
@jekyllbot
Update history to reflect merge of #6525 [ci skip]
efd9864
@ashmaroli ashmaroli deleted the use-kernel-Array branch November 6, 2017 14:37
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @pathawks @DirtyF @jekyllbot
0