8000 Site: Add default twitter card image by jekyllbot · Pull Request #6476 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Site: Add default twitter card image #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Conversation

jekyllbot
Copy link
Contributor
@jekyllbot jekyllbot commented Oct 23, 2017
Given I share a post from jekyllrb.com
Then Twitter Card displays the Jekyll logo by default

Current status:
capture d ecran 2017-10-23 a 21 07 05

Hopefully we use jekyll-seo-tag who can take care of that 😄

PR automatically created for @DirtyF.

Site: Add default twitter card image

@DirtyF DirtyF added the site label Oct 23, 2017
@DirtyF DirtyF requested a review from a team October 23, 2017 19:10
@parkr
Copy link
Member
parkr commented Oct 23, 2017

Does it expand out to use site.url?

@DirtyF
Copy link
Member
DirtyF commented Oct 23, 2017

@parker it does according to my tests, I basically followed the plugin documentation. I trust @benbalter on this 😄

@DirtyF
Copy link
Member
DirtyF commented Oct 23, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 8d88ee9 into master Oct 23, 2017
@jekyllbot jekyllbot deleted the pull/site-twitter-card branch October 23, 2017 19:21
jekyllbot added a commit that referenced this pull request Oct 23, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0