8000 Add `{% raw %}` to Liquid example on site by adamvoss · Pull Request #6179 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add {% raw %} to Liquid example on site #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2017
Merged

Add {% raw %} to Liquid example on site #6179

merged 1 commit into from
Jun 25, 2017

Conversation

adamvoss
Copy link
Contributor
@adamvoss adamvoss commented Jun 25, 2017 •
edited by DirtyF
Loading

Fix for #6165 (comment)

Discussion: #6165 (comment)
I can change it to escaping the braces if that is what is ultimately wanted.

/cc @jekyll/documentation

@pathawks
Copy link
Member

I worry this makes it less obvious that the code is Liquid.

I understand that {{ site.collections | where: "label", "myCollection" | first }} is not the most useful code, but if I copy-paste it into my site, I will get something that works, and it should be fairly simple to bend it to whatever task I am trying to accomplish.

I think throughout the site we use {{ }} and {% %} to denote Liquid syntax.
I think (hope) we use {{ }} consistently when describing filters and {% %} when describing tags.

ashmaroli
ashmaroli requested changes Jun 25, 2017
View reviewed changes
docs/_docs/collections.md Outdated
@@ -310,7 +310,7 @@ you specified in your `_config.yml` (if present) and the following information:
when iterating through <code>site.collections</code> as you may need to
filter it out.</p>
<p>You may wish to use filters to find your collection:
<code>{{ site.collections | where: "label", "myCollection" | first }}</code></p>
<code>site.collections | where: "label", "myCollection" | first</code></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope this should be

<code>{% raw %}{{ site.collections | where: "label", "myCollection" | first }}{% endraw %}</code>

That's how it is elsewhere in our docs.
The priority is for how it renders at jekyllrb.com/docs rather than github.com

@ashmaroli
Copy link
Member

..and the PR title needs to edited as well. We're no longer removing the braces..

@pathawks pathawks changed the title Remove braces to Jekyll does not try to process as Liquid Add {%raw%} to Liquid example on site Jun 25, 2017
@pathawks
Copy link
Member

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 17c888d into jekyll:master Jun 25, 2017
jekyllbot added a commit that referenced this pull request Jun 25, 2017
@jekyllbot
Update history to reflect merge of #6179 [ci skip]
e836de3
@DirtyF DirtyF changed the title Add {%raw%} to Liquid example on site Add {% raw %} to Liquid example on site Jul 29, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli requested changes

@pathawks pathawks pathawks approved these changes

Assignees

@parkr parkr

@jekyllbot jekyllbot

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamvoss @pathawks @ashmaroli @parkr @jekyllbot
0