8000 Backward compatiblize URLFilters module by ashmaroli · Pull Request #6163 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backward compatiblize URLFilters module #6163

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2017
Merged

Backward compatiblize URLFilters module #6163

merged 1 commit into from
Jun 21, 2017

Conversation

ashmaroli
Copy link
Member

#6058 introduced a private method :site to Jekyll::Filters::URLFilters that created unforeseen bugs when the module got extended. This PR reverts that private_method to oblivion.

/cc @jekyll/ecosystem @benbalter

@ashmaroli ashmaroli force-pushed the patch-url-filters branch from 952f5be to b548aa9 Compare June 20, 2017 17:09
@parkr parkr requested a review from benbalter June 20, 2017 17:12
@pathawks
Copy link
Member

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 7a85376 into jekyll:master Jun 21, 2017
jekyllbot added a commit that referenced this pull request Jun 21, 2017
@jekyllbot
Update history to reflect merge of #6163 [ci skip]
19a8458
@pathawks
Copy link
Member

@parkr It'd be cool to get this fix out quickly.

@jekyll/ecosystem I wonder if we could do a better job testing Jekyll with some popular plugins before we release, just to make sure we aren't unknowingly breaking anything major the way this did. Breaking most (all?) of our own plugins doing a point update is not a great look.

@pathawks
Copy link
Member

@ashmaroli Thank you for fixing this so quickly 🍻♥️

@parkr
Copy link
Member
parkr commented Jun 21, 2017

@parkr It'd be cool to get this fix out quickly.

Happy to release if someone wants to put together a release post.

@pathawks
Copy link
Member

@ashmaroli?

Otherwise, I’d be happy to do so tonight.

@ashmaroli
Copy link
Member Author

@pathawks Thank you. But, I'll let you do the honors.
Before we release, have we tested the failing plugins against the master branch of this repo to be sure..?

@pathawks
Copy link
Member
pathawks commented Jun 22, 2017 •
edited
Loading

Before we release, have we tested the failing plugins against the master branch of this repo to be sure..?

It looks like this fixes the URL issues, but not the static files frontmatter issue (jekyll/jekyll-sitemap#176)

@parkr
Copy link
Member
parkr commented Jun 22, 2017

@pathawks That's fine. @benbalter is working on a fix in #6162.

@ashmaroli ashmaroli deleted the patch-url-filters branch June 22, 2017 06:40
@ashmaroli ashmaroli mentioned this pull request Jun 26, 2017
Closed
5 tasks
@benbalter benbalter mentioned this pull request Jun 29, 2017
Closed
@Crunch09 Crunch09 mentioned this pull request Jun 30, 2017
Closed
@outcoldman
Copy link

@pathawks any updates on the release? Seems like this plugin is broken jekyll-redirect-from

@pathawks
Copy link
Member
pathawks commented Jul 1, 2017

@outcoldman Yeah, just waiting on #6162. Sorry.

@outcoldman
Copy link

@pathawks seems like it got merged as well! thank you for taking care of it, hope to see 3.5.1 pretty soon 👍

@benbalter benbalter mentioned this pull request Jul 6, 2017
Closed
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@benbalter benbalter benbalter approved these changes

Assignees

@pathawks pathawks

Labels
fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ashmaroli @pathawks @parkr @outcoldman @DirtyF @benbalter @jekyllbot
0