8000 Define path with __dir__ by bogdanvlviv · Pull Request #6087 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Define path with __dir__ #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2017
Merged

Define path with __dir__ #6087

merged 1 commit into from
Jul 25, 2017

Conversation

bogdanvlviv
Copy link
Contributor
@bogdanvlviv bogdanvlviv commented May 24, 2017 •
edited
Loading

".. with __dir__ we can restore order in the Universe."

parkr
parkr approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. FWIW, Kernel#__dir__ is a method, where __FILE__ is a parse-time constant, so this is a bit slower than using __FILE__ directly, but we're basically always using it with a call to File.dirname so no harm done.

parkr
parkr requested changes Jun 14, 2017
View reviewed changes
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. This seems to have broken the tests. We'll need to sort that out first.

@parkr parkr added the internal label Jun 14, 2017
@bogdanvlviv
Define path with __dir__
39e232a 
".. with __dir__ we can restore order in the Universe."
@bogdanvlviv
Copy link
Contributor Author

@parkr Thank you for the review! I finally finished this PR.

@bogdanvlviv
Copy link
Contributor Author

@parkr please review

@parkr
Copy link
Member
parkr commented Jul 25, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8f1959b into jekyll:master Jul 25, 2017
jekyllbot added a commit that referenced this pull request Jul 25, 2017
@jekyllbot
Update history to reflect merge of #6087 [ci skip]
590dd6c
@parkr
Copy link
Member
parkr commented Jul 25, 2017

Thank you, @bogdanvlviv! The consistency is wonderful.

@bogdanvlviv
Copy link
Contributor Author

@parkr Thanks!

@bogdanvlviv bogdanvlviv deleted the define-path-with__dir__ branch July 26, 2017 07:26
This was referenced Aug 24, 2017
Merged
Merged
Merged
msael
msael reviewed Apr 29, 2018
View reviewed changes
Copy link
@msael msael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey how

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@msael msael msael left review comments

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdanvlviv @parkr @msael @jekyllbot
0