8000 Standardise on "URLs" without apostrophe in docs by zarino · Pull Request #6018 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Standardise on "URLs" without apostrophe in docs #6018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2017
Merged

Standardise on "URLs" without apostrophe in docs #6018

merged 1 commit into from
Apr 11, 2017

Conversation

zarino
Copy link
Contributor
@zarino zarino commented Apr 11, 2017

I was browsing the Jekyll docs earlier (https://jekyllrb.com/docs/github-pages/) and noticed you were using a mixture of "URLs", "URL’s" (with curly quote) and "URL's" (with straight quote).

screenshot of documentation with urls marked

Apostrophes are unnecessary when pluralising acronyms,[1][2] and avoiding them also makes it easier for readers less familiar with the English language.

So I’ve replaced URL\S?s with URLs across the docs directory, and History.markdown. There was no need to change any of the Ruby code files.

I hope I’ve correctly followed all the guidelines for contributing to Jekyll – but if there’s anything you’d like me to change, let me know. 👍

DirtyF
DirtyF approved these changes Apr 11, 2017
View reviewed changes
Copy link
Member
@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zarino for helping us improving documentation.

History is automatically generated from commits messages but from now on we'll try to stick to this convention.

ghost
ghost approved these changes Apr 11, 2017
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost
Copy link
ghost commented Apr 11, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 034f03e into jekyll:master Apr 11, 2017
jekyllbot added a commit that referenced this pull request Apr 11, 2017
@jekyllbot
Update history to reflect merge of #6018 [ci skip]
4e82518
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarino @DirtyF @jekyllbot
0