8000 Filters#time helper: Duplicate time before calling #localtime. by parkr · Pull Request #5996 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Filters#time helper: Duplicate time before calling #localtime. #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2017
Merged

Filters#time helper: Duplicate time before calling #localtime. #5996

merged 1 commit into from
Mar 31, 2017

Conversation

parkr
Copy link
Member
@parkr parkr commented Mar 31, 2017 •
edited
Loading

Failure noticed on master: https://travis-ci.org/jekyll/jekyll/jobs/217231764

In Ruby 2.4, Time#localtime modifies the Time instance.
In Ruby 2.3, Time#localtime appears to leave them alone.

Either that, or #to_time used to duplicate and now it doesn't.

@parkr
Filters#time helper: Duplicate time before calling #localtime.
1c42d07 
In Ruby 2.4, Time#localtime modifies the Time instance.
In Ruby 2.3, Time#localtime appears to leave them alone.
@parkr parkr requested a review from pathawks March 31, 2017 16:59
@parkr
Copy link
Member Author
parkr commented Mar 31, 2017

/cc @jekyll/stability

pathawks
pathawks approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member
@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird.

@parkr
Copy link
Member Author
parkr commented Mar 31, 2017

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit faf5be4 into master Mar 31, 2017
@jekyllbot jekyllbot deleted the duplicate-time-before-call-of-localtime branch March 31, 2017 18:44
jekyllbot added a commit that referenced this pull request Mar 31, 2017
@jekyllbot
Update history to reflect merge of #5996 [ci skip]
5510313
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pathawks pathawks pathawks approved these changes

Assignees

@parkr parkr

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parkr @pathawks @jekyllbot
0