Specify version constraint in subcommand error message. #5974
8000Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the following error message:
You must install the 'jekyll-docs' gem to use the 'jekyll docs' command.
by including the required version
You must install the 'jekyll-docs' gem version = 3.4.0 to use the 'jekyll docs' command.
This removes ambiguity.
7911e8d to
14df2b6
Compare
|
Request: Can the message from |
DirtyF
approved these changes
Mar 22, 2017
@ashmaroli Can you please support that request with motivation? |
Um, just a personal nit, I gez.. Nevermind then. |
|
A method to get the version constraint of a given gem and dependency: def version_constraint(gem_name, dep_name)
deps = Gem::Specification.find_by_name(gem_name.to_s).runtime_dependencies
deps.find { |d| d.name == dep_name.to_s }.requirements_list.join(", ")
end
# version_constraint("jekyll-docs", "jekyll")
# => "= 3.4.0" |
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the following error message:
by including the required version
This removes ambiguity.
The technical solution is no fun (makes "magical" assumptions) but I
couldn't get the RubyGems
GemAPI to play nice and tell me whatconstraint is required. Does anyone else know how to do that?
/cc @jekyll/stability