Add missing merge labels for jekyllbot #5753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
requested changes
Jan 11, 2017
| @@ -38,8 +38,9 @@ The categories match the H3's in the history/changelog file, and they are: | |||
| 1. Major Enhancements (`+major`) – major updates or breaking changes to the code which necessitate a major version bump (v3 ~> v4) | |||
| 2. Minor Enhancements (`+minor`) – minor updates (feature, enhancement) which necessitate a minor version bump (v3.1 ~> v3.2) | |||
| 3. Bug Fixes (`+bug`) – corrections to code which do not change or add functionality, which necessitate a patch version bump (v3.1.0 ~> v3.1.1) | |||
| 4. Site Enhancements (`+site`) – changes to the source of https://jekyllrb.com, found in `site/` | |||
| 4. Site Enhancements (`+site` or `+doc`) – changes to the source or the documentation found in `docs/` and published on https://jekyllrb.com, | |||
There was a problem hiding this comment.
I think +doc routes to Documentation, not Site Enhancements. https://github.com/parkr/auto-reply/blob/e5c55feb1811aad9f2426fbe49891c50a3376e8f/chlog/merge_and_label.go#L54-L59
| 5. Development Fixes (`+dev`) – changes which do not affect user-facing functionality or documentation, such as test fixes or bumping internal dependencies | ||
| 6. Forward Ports (`+port`) — forward-port changes, e.g. from v3.1.4. |
There was a problem hiding this comment.
"forward-port changes" doesn't really describe this well if you don't know what forward-porting is supposed to mean. How about:
Forward Ports (
+port) – bug fixes applied to a previous version of Jekyll pulled ontomaster, e.g. cherry-picked commits from3-1-stabletomaster
?
pathawks
approved these changes
Jan 11, 2017
parkr
approved these changes
Jan 18, 2017
|
@jekyllbot: merge +doc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docandport-forwardwere missing.source: https://github.com/parkr/auto-reply/blob/e5c55feb1811aad9f2426fbe49891c50a3376e8f/chlog/merge_and_label.go#L30-L70
/cc @jekyll/core