8000 Sort gems by DirtyF · Pull Request #5746 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sort gems #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2017
Merged

Sort gems #5746

merged 4 commits into from
Jan 10, 2017

Conversation

DirtyF
Copy link
Member
@DirtyF DirtyF commented Jan 9, 2017

À la Rubocop.

/cc @jekyll/core

parkr
parkr approved these changes Jan 9, 2017
View reviewed changes
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuure!

ashmaroli
ashmaroli requested changes Jan 10, 2017
View reviewed changes
Copy link
Member
@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one lone comment.. 😉

jekyll.gemspec
s.add_runtime_dependency("jekyll-sass-converter", "~> 1.0")
s.add_runtime_dependency("jekyll-watch", "~> 1.1")
s.add_runtime_dependency("kramdown", "~> 1.3")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before: the whitespace after gem-name improved readability

gemsp

after: it just looks weird..

gemspe

suggestion: normalize whitespace and improve readability. 😃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ghost
Copy link
ghost commented Jan 10, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 8a02606 into jekyll:master Jan 10, 2017
jekyllbot added a commit that referenced this pull request Jan 10, 2017
@jekyllbot
Update history to reflect merge of #5746 [ci skip]
0210022
@DirtyF DirtyF deleted the sort-gems branch January 10, 2017 09:56
@parkr
Copy link
Member
parkr commented Jan 10, 2017

@quiltbag For future reference, this probably should have been +dev or +site, as it doesn't affect any of Jekyll's runtime code (lib/).

@ghost
Copy link
ghost commented Jan 10, 2017

@parkr okay! do we have a reference for those flags somewhere?

@parkr
Copy link
Member
parkr commented Jan 10, 2017

@quiltbag 😄 General docs are here: http://jekyllrb.com/docs/maintaining/ and for this specifically, http://jekyllrb.com/docs/maintaining/merging-a-pull-request/#merging – no big deal, I just updated it in 2236889.

@ghost
Copy link
ghost commented Jan 10, 2017

@parkr thanks :o i didn't see that doc

@parkr
Copy link
Member
parkr commented Jan 10, 2017

@quiltbag No problem at all! Feel free to reach out with any questions.

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli requested changes

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DirtyF @parkr @ashmaroli @jekyllbot
0