Fix #5730: add gcc and make to the list of requirements #5731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
reviewed
Jan 7, 2017
| @@ -21,6 +21,7 @@ requirements you’ll need to make sure your system has before you start. | |||
| - [NodeJS](https://nodejs.org/), or another JavaScript runtime (Jekyll 2 and | |||
| earlier, for CoffeeScript support). | |||
| - [Python 2.7](https://www.python.org/downloads/) (for Jekyll 2 and earlier) | |||
| - [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed) | |||
There was a problem hiding this comment.
Should we include a way to check whether these are installed, e.g. gcc --version and make --version?
There was a problem hiding this comment.
@parkr Yes, that seems great. Also, gcc -v and make -v work as well, so we can use the shorter versions.
What syntax do you suggest for adding the information? A note, a code block or just inline code?
|
Fixes #5730. |
|
Updated. |
|
@jekyllbot: merge +site |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am just unsure should we provide the link to the GNU make page, as it's dull and its installation instructions are nothing less dull. Also, make can be installed via the
build-essentialspackage.