Use Addressable instead of URI to decode #5726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4719 |
1cb4519 to
6fb05e0
Compare
1cb4519 to
5652c10
Compare
7a8c2eb to
1e4b779
Compare
pathawks
reviewed
Jan 7, 2017
| @@ -145,7 +145,8 @@ def self.escape_path(path) | |||
| # 8000 pct-encoded = "%" HEXDIG HEXDIG | |||
| # sub-delims = "!" / "$" / "&" / "'" / "(" / ")" | |||
| # / "*" / "+" / "," / ";" / "=" | |||
| URI.escape(path, %r{[^a-zA-Z\d\-._~!$&'()*+,;=:@\/]}).encode("utf-8") | |||
| path = Addressable::URI.encode(path) | |||
| path.encode("utf-8").sub("#", "%23") | |||
There was a problem hiding this comment.
Aside from escaping # (which I cannot understand), Addressable seems to perfectly fit our needs 👍
ghost
approved these changes
Jan 7, 2017
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR automatically created for @pathawks.