test double slash when input = '/' #5542
Conversation
|
/cc @benbalter |
| "url" => "http://example.com", | ||
| "baseurl" => nil | ||
| }) | ||
| refute_equal "http://example.com//", filter.absolute_url(page_url) |
| "url" => "http://example.com", | ||
| "baseurl" => "/base" | ||
| }) | ||
| refute_equal "http://example.com/base//", filter.absolute_url(page_url) |
There was a problem hiding this comment.
Can we assert that it is proper, rather than refuting this particular wrong case?
|
@benbalter, does this look good to you? I don't see a failing test in the history and I don't trust my reading well enough since I was the one who let this slip through in the first place. 😸 |
|
Shouldn't these tests currently be failing? Was something else causing jekyll/jekyll-feed#145? |
|
I was not able to reproduce the error on my Windows machine. Hence wrote these tests to have Travis check it.. |
|
What's up with AppVeyor? |
@pathawks the test log pre-dates fixing AppVeyor on the |
|
Always good to have extra tests for things like this. @jekyllbot: merge +bug |
|
@parkr I think it would be better that @jekyllbot adds a single label |
test #5541