8000 include a hashbang for all benchmark scripts & make them executable · Pull Request #5505 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

include a hashbang for all benchmark scripts & make them executable #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 24, 2016
Merged

include a hashbang for all benchmark scripts & make them executable #5505

merged 1 commit into from Oct 24, 2016

Conversation

ghost
Copy link
@ghost ghost commented Oct 22, 2016

i have no idea what the circumstances of the benchmark scripts are (i cant even find their usage anywhere in the repo) but it's weird how some files have a hashbang, and even then, none of them are executable. this PR adds hashbangs (#!/usr/bin/env ruby, to be precise) to all benchmark files and makes them executable.

include a hashbang for all benchmark scripts
7729d12 
this also makes every benchmark script executable
@DirtyF DirtyF added the tests label Oct 22, 2016
@DirtyF
Copy link
Member
DirtyF commented Oct 22, 2016

/cc @jekyll/core

parkr
parkr approved these changes Oct 24, 2016
View reviewed changes
Copy link
Member
@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I usually do BENCHMARK=true bundle exec ruby benchmark/<file> to run them so I never bothered adding them or making them executable.

@parkr
Copy link
Member
parkr commented Oct 24, 2016

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit bc5e59c into jekyll:master Oct 24, 2016
jekyllbot added a commit that referenced this pull request Oct 24, 2016
@jekyllbot
Update history to reflect merge of #5505 [ci skip]
ce6f20f
@ghost
Copy link
Author
ghost commented Oct 25, 2016

it's just for consistency anyway!

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@parkr parkr

Labels
fix frozen-due-to-age internal tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DirtyF @parkr @jekyllbot
0