-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[docs] add help for missing static_file e.g. on heroku #5334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| If you run into an issue that a static file can't be found in your | ||
| production environment during build since v3.2.0 you should set your | ||
| [environment to `production`](https://jekyllrb.com/docs/configuration/#specifying-a-jekyll-environment-at-build-time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use relative link here instead please? (../configuration/#specifying-a-jekyll-environment-at-build-time) Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with removing the domain but I don't get the logic behind a relative link? Unless Jekyll has some magic that makes these absolute they should be absolute, having links relative makes it hard to change the name of a page and while it might be rare it can happen and this makes that move more expensive than it ever should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@envygeeks Got it. I'll open another PR to fix this globally, because there are already some relative links elsewhere in the docs.
|
Confirmed, that solved the issue for me, I set the JEKYLL_ENV to production in heroku and build was successfull. Thanks @Crunch09! |
|
LGTM. |
|
@jekyllbot: merge +site |
|
IMO the description is a bit unclear. It's not specifically a production problem but rather a problem for possibly any site with symlinks that break when copied elsewhere (namely to On Heroku this happens also for sites without any symlinks, since Heroku seems to add some. @envygeeks The statement in #5144 that this problem is caused by 0f74db4 is wrong; I did some further tests and wanted to add a corresponding comment there, |
Hi,
as described in #5144 somehow on Heroku a
bin/erbfile couldn't be found during build. This was a symlinked file and it couldn't be copied because of the reasons @parkr pointed out in #4640 (comment) .I wasn't sure if i should also rescue the exception in the
static_file.rband provide a better error message in the log, so for now there is only a new section in the troubleshooting doc.I would be glad if @xuanxu and / or @stomar could confirm if their site is building again after they set their jekyll environment to
production.cc: @jekyll/documentation