8000 Site documentation section links always point to https://jekyllrb.com by Anthony-Gaudino · Pull Request #5281 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Site documentation section links always point to https://jekyllrb.com #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2016
Merged

Site documentation section links always point to https://jekyllrb.com #5281

merged 1 commit into from
Aug 27, 2016

Conversation

Anthony-Gaudino
Copy link
Contributor
@Anthony-Gaudino Anthony-Gaudino commented Aug 24, 2016 •
edited
Loading

On the site documentation section, links to documentation sections always point to the jekyllrb.com website, this means that users testing changes might get confused because they will see the official external website page instead of their local website upon clicking those links.

Please check if this change doesn't break the links on the official website on https://jekyllrb.com before accepting the pull request.

@jekyll/documentation

@Anthony-Gaudino
On the site documentation section, links to documentation items point…
df1cafd 
… to the "jekyllrb.com" website, this means that users testing changes might get confused because they will see the official external website instead of their local website upon clicking those links.
8000
@Anthony-Gaudino
Copy link
Contributor Author

@jekyll/documentation

@ashmaroli
Copy link
Member
ashmaroli commented Aug 24, 2016 •
edited
Loading

Hi..
I think there's another way around this issue. But, it requires an extra step from the testing user's end.
What they need to do is edit the url parameter inside site/_config.yml from https://jekyllrb.com to http://localhost:4000

Update: Nah. Not a good idea as _config.yml would get chucked into their PR as well.

@ashmaroli
Copy link
Member

@parkr, jekyllbot commented twice here. Once without description, then again with proper description when another user (myself) commented.
Bug?

@DirtyF
Copy link
Member
DirtyF commented Aug 24, 2016 •
edited
Loading

I guess we could use a _development.yml config file to override _config.yml url value but I don't know how to pass a --config option to the preview task in site.rake

@Anthony-Gaudino
Copy link
Contributor Author

Maybe the changes on this pull request won't do any harm, only the links on the documentation section have the {{ site.url }} and the changes only affect the list of links to documentation sections.

It's a good idea for someone that knows how the site is hosted to look at this pull request just to make sure this won't break the links on the official website.

Another option is to just accept the pull request and check the site after rebuild, if something is wrong, revert.

@parkr
Copy link
Member
parkr commented Aug 26, 2016

This works fine for me! LGTM.

/cc @jekyll/documentation

@jekyllbot jekyllbot self-assigned this Aug 26, 2016
@parkr
Copy link
Member
parkr commented Aug 27, 2016

LOL, @jekyllbot. 😄

@parkr parkr assigned DirtyF and unassigned jekyllbot Aug 27, 2016
@parkr
Copy link
Member
parkr commented Aug 27, 2016 •
edited
Loading

@jekyllbot: merge +site

🤷

@jekyllbot jekyllbot merged commit 1979426 into jekyll:master Aug 27, 2016
jekyllbot added a commit that referenced this pull request Aug 27, 2016
@jekyllbot
Update history to reflect merge of #5281 [ci skip]
488496a
@DirtyF
Copy link
Member
DirtyF commented Aug 27, 2016

@Anthony-Gaudino it's fine on http://jekyllrb.com/ ❤️ thanks!

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@DirtyF DirtyF

Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anthony-Gaudino @ashmaroli @DirtyF @parkr @jekyllbot
0