{{ message }}
Add support for indented link references on excerpt #5212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b8843d to
735b3b8
Compare
|
Why would a reference be indented like this? Also, can you add tests for this instead of modifying pre-existing ones? Thanks! |
735b3b8 to
1275a59
Compare
I think that it makes it more readable, it seems that stack overflow thinks the same.
I think that adding more tests could make the test suite harder to read, but I've changed that as requested. |
The test suite isn't there for you to read, it's there for us to make sure what you do works. |
|
Any news about this PR? The failing tests are not related to the introduced changes. |
|
@eloyesp I restarted the tests and they failed a second time, can you double check your changes didn't cause the failure please! |
|
Failure is because you added a post to the test site, so the number of generated posts is different from what the test suite expects. |
1275a59 to
371d21b
Compare
|
thanks @pathawks, It's fixed now. |
| --- | ||
| --- | ||
|
|
||
| This is the first paragraph. It [have][link_0] [lots][link_1] [of][link_2] |
Excerpt link reference extraction is missing all the indented references at the bottom of the page. Markdown specify that those can be indented up to three spaces.
371d21b to
9b09d8a
Compare
|
LGTM. |
|
LGTM. |
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpt link reference extraction is missing all the indented references
at the bottom of the page. Markdown specify that those can be indented up
to three spaces.
I've also added a title to the link in the test.