8000 Adds ability to link to all files by jeffkole · Pull Request #5199 · jekyll/jekyll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds ability to link to all files #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2016
Merged

Adds ability to link to all files #5199

merged 3 commits into from
Sep 13, 2016

Conversation

jeffkole
Copy link
Contributor
@jeffkole jeffkole commented Aug 3, 2016

Fixes request made in #4624 and bug found in #5182

@jeffkole
Adds ability to link to all files
82d6657 
Fixes request made in jekyll#4624 and bug found in jekyll#5182
@jeffkole jeffkole mentioned this pull request Aug 3, 2016
Merged
@envygeeks
Copy link
Contributor

What bug? I see no bug in that documentation.

@DirtyF DirtyF mentioned this pull request Aug 4, 2016
Merged
@DirtyF
Copy link
Member
DirtyF commented Aug 4, 2016 •
edited
Loading

Thanks @jeffkole link to pages and files works fine now :)

I tested it a bit and noticed that you have to use add a / before the path to a file or Jekyll won't find the file.

{% link /assets/files/doc.pdf %}

Also, just so you know I didn't manage to link to a data file with {% link _data/file.yml %} but's it's out of the scope of this fix I guess.

@envygeeks it wasn't a bug in the documentation but rather in the implementation of the brand new linktag, hence this PR

@parkr
Copy link
Member
parkr commented Aug 5, 2016

@jeffkole Because you added a file to the test fixture site, you have to update another test: https://travis-ci.org/jekyll/jekyll/jobs/149605617

@jeffkole
Copy link
Contributor Author
jeffkole commented Aug 5, 2016

@DirtyF That is annoying, isn't it. Looks like static files get a leading slash added to their relative path property. I'll check in a fix.

@parkr
Copy link
Member
parkr commented Aug 6, 2016

LGTM!

parkr added a commit that referenced this pull request Aug 7, 2016
@parkr
templates.md: {% link %} tag only accepts collection documents
ab4abb1 
Remove examples of pages/static file links until it's released.
#5182 #5199
@DirtyF
Copy link
Member
DirtyF commented Sep 13, 2016 •
edited
Loading

cc / @jekyll/core

@envygeeks
Copy link
Contributor

I like that it has tests. Thanks for adding tests. LGTM.

@envygeeks
Copy link
Contributor

Since I don't remember the tag for a feature +minor? I'll let @parkr or somebody else on @jekyll/core deal with the merge.

@mattr-
Copy link
Member
mattr- commented Sep 13, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 4888b84 into jekyll:master Sep 13, 2016
jekyllbot added a commit that referenced this pull request Sep 13, 2016
@jekyllbot
Update history to reflect merge of #5199 [ci skip]
57fd5f8
@mattr-
Copy link
Member
mattr- commented Sep 13, 2016

@envygeeks you were right. It's +minor. 😃

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeffkole @envygeeks @DirtyF @parkr @mattr- @jekyllbot
0