8000 Add conda-forge version badge by zmoon · Pull Request #72 · jbusecke/xmovie · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add conda-forge version badge #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2021
Merged

Add conda-forge version badge #72

merged 4 commits into from
Dec 21, 2021

Conversation

zmoon
Copy link
Contributor
@zmoon zmoon commented Dec 12, 2021

Resolves #52

@codecov
Copy link
codecov bot commented Dec 12, 2021 •
edited
Loading

Codecov Report

Merging #72 (1fe98f4) into master (023abcb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files           3        3           
  Lines         324      324           
  Branches       59       59           
=======================================
  Hits          258      258           
  Misses         43       43           
  Partials       23       23
Flag Coverage Δ
unittests 79.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023abcb...1fe98f4. Read the comment docs.

@jbusecke
Copy link
Owner

Do you think we should remove the pypi badge altogether?

@zmoon
Copy link
Contributor Author
zmoon commented Dec 15, 2021

Hmm, I don't mind it, it provides a confirmation that they are in sync. But removing the PyPI badge could help position conda-forge as the preferred install method, which could be good.

@jbusecke
Copy link
Owner

Hmm, I don't mind it, it provides a confirmation that they are in sync.
I think that is desirable.

how about we put pypi behind conda?

@zmoon
Copy link
Contributor Author
zmoon commented Dec 15, 2021 •
edited
Loading

how about we put pypi behind conda?

Yeah that seems like a good idea. And I can also add the RTD badge, maybe after the CI status one.

@jbusecke
Copy link
Owner

Yeah that seems like a good idea. And I can also add the RTD badge, maybe after the CI status one.

Absolutely! I am all for more badges!

@zmoon
Copy link
Contributor Author
zmoon commented Dec 16, 2021

@jbusecke I added those new changes, should be ready to go if you are pleased with how it looks here

@jbusecke
Copy link
Owner

Dope! Thanks a lot.

@jbusecke
Copy link
Owner

Oh you should most definitely add a line to the docs/whats-new.rst too.

@zmoon
Copy link
Contributor Author
zmoon commented Dec 20, 2021

Oh you should most definitely add a line to the docs/whats-new.rst too.

Done!

jbusecke
jbusecke approved these changes Dec 21, 2021
View reviewed changes
Copy link
Owner
@jbusecke jbusecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horray! Always good to close the old year out with more badges!

@jbusecke jbusecke merged commit 3e00813 into jbusecke:master Dec 21, 2021
@zmoon zmoon deleted the badge branch May 3, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbusecke jbusecke jbusecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add conda badge
2 participants
@zmoon @jbusecke
0