Specify past or future datetime for frame start or restart with an command line option #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
reviewed
Sep 16, 2018
| if from_: | ||
| # modify the current frame with optional start time instead of "now" | ||
| watson.current = dict(start=from_, project=project, tags=tags) | ||
| current = watson.current |
There was a problem hiding this comment.
Why not choosing to hack around the watson.start method?
There was a problem hiding this comment.
Why add more code and complexity if same result can be achieved with more elegant solution? Of course the elegance is in the eye of the beholder (and committer in this case :))
|
@braincow What's the state of this PR ? I'd really like to see it merged ! |
|
Ping @braincow ? |
|
Thank you, @braincow Could you rebase your branch to resolve the conflicts? It would be easier for others to cherry pick the changes and hopefully they get merged soon. |
This was referenced Apr 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #75 feature request was made for ability to specify start time for frames that are started and should be considered already running.
This pull request outlines a simple proposal for achieving this.
Pull request does not implement: