8000 Fix incomplete renaming of variable (fixes #158) by SpotlightKid · Pull Request #159 · jazzband/Watson · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incomplete renaming of variable (fixes #158) #159

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

SpotlightKid
Copy link
Contributor

Signed-off-by: Christopher Arndt chris@chrisarndt.de

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@willdurand willdurand requested a review from k4nar August 1, 2017 12:07
@SpotlightKid
Copy link
Contributor Author
  • Old line 871 (watson.config = config) was unnecessary, because both references already point to the same object.

  • We should really have CLI tests.

@jmaupetit
Copy link
Contributor

Thank you for this Chris!

We should really have CLI tests.

Yup. Thought about it yesterday. I will handle this.

Copy link
Contributor
@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmaupetit
Copy link
Contributor

We'll need to release this in a 1.5.1

@willdurand
Copy link
Contributor

LGTM too. @jmaupetit could you merge and release a new version please?

@willdurand
Copy link
Contributor

or someone else with PyPI push access.

@k4nar
Copy link
Collaborator
k4nar commented Aug 1, 2017

I can do the release.

@k4nar
Copy link
Collaborator
k4nar commented Aug 1, 2017

There was only documentation changes so far, so I'll do the 1.5.1 from master.

@k4nar k4nar merged commit 19a49a8 into jazzband:master Aug 1, 2017
@willdurand
Copy link
Contributor

👍 perfect and Hi! it's been a long time :)

the doc change was about the release process, so it should be useful to you

@k4nar
Copy link
Collaborator
k4nar commented Aug 1, 2017

Done :) .

@jmaupetit
Copy link
Contributor
8000 jmaupetit commented Aug 1, 2017

Thx @k4nar !

jmaupetit pushed a commit that referenced this pull request Aug 2, 2017
New configuration was never saved on disk.

Follow up of #159 & #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0