8000 work around unhashable named shapes in `ShapeDtypeStruct` by froystig · Pull Request #8183 · jax-ml/jax · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

work around unhashable named shapes in ShapeDtypeStruct #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

work around unhashable named shapes in ShapeDtypeStruct #8183

merged 2 commits into from
Oct 12, 2021

Conversation

froystig
Copy link
Member
@froystig froystig commented Oct 12, 2021 •
edited
Loading

Addresses the hashing bug mentioned in #8182 in the near term.

Also updates NamedShape's hash to be similarly order-independent.

@froystig froystig added the pull ready Ready for copybara import and testing label Oct 12, 2021
@froystig froystig requested a review from jekbradbury October 12, 2021 20:31
@froystig froystig self-assigned this Oct 12, 2021
@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@copybara-service copybara-service bot merged commit 075d835 into jax-ml:main Oct 12, 2021
@froystig froystig deleted the named-shape-hash branch October 13, 2021 01:48
@froystig froystig mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaszke apaszke apaszke approved these changes

@jekbradbury jekbradbury Awaiting requested review from jekbradbury

Assignees

@froystig froystig

Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@froystig @apaszke @kokoro-team
0