10000 Copy between instances not working · Issue #864 · jarun/nnn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Copy between instances not working #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hankchiutw opened this issue Mar 4, 2021 · 9 comments
Closed

Copy between instances not working #864

hankchiutw opened this issue Mar 4, 2021 · 9 comments
Labels
question

Comments

@hankchiutw
Copy link

Environment details (Put x in the checkbox along with the information)

[x] Operating System: macOS 10.12.6
[ ] Desktop Environment:
[ ] Terminal Emulator:
[x] Shell: fish
[ ] Custom desktop opener (if applicable):
[ ] Program options used:
[ ] Configuration options set:
[x] Issue exists on nnn master: v3.5

Exact steps to reproduce the issue

Install by brew install --HEAD nnn.
Follow the comment: #137 (comment). Specifically:

in first instance, selected a file with ^K.
in second instance, used P to paste the file

Are the key bindings removed now? If so, how could I copy files between nnn instances?
@hankchiutw hankchiutw added the bug label Mar 4, 2021
@KlzXS
Copy link
Collaborator
KlzXS commented Mar 4, 2021

Those are keybinds for on old version. The comment you linked is from 2018.

Use ? to display the current keybinds. Nowdays the keybinds are considered to be final.

@KlzXS KlzXS closed this as completed Mar 4, 2021
@KlzXS KlzXS added question and removed bug labels Mar 4, 2021
@hankchiutw
Copy link
Author

Then, my question is how could I copy files between nnn instances?
I have tried:

  • in first instance, selected a file with Space.
  • in second instance, used p to paste the file

It just hints 0 selected in the second instance.

@hankchiutw hankchiutw mentioned this issue Mar 4, 2021
Open
@KlzXS
Copy link
Collaborator
KlzXS commented Mar 4, 2021

You are running off master right? I tested it with v3.0 I have lying around and it works fine. I'll test master a bit later.

jarun added a commit that referenced this issue Mar 4, 2021
@jarun
Fix #864
c7140e6
@jarun
Copy link
Owner
jarun commented Mar 4, 2021

@hankchiutw please test the patch and confirm it works as expected.

@jarun jarun mentioned this issue Mar 4, 2021
Closed
21 tasks
@KlzXS
Copy link
Collaborator
KlzXS commented Mar 4, 2021

That fixes it on my end. But it brings back the problems from #855
We need something that will fix both.

jarun added a commit that referenced this issue Mar 4, 2021
@jarun
Fix regression in #864
831c7bb
@jarun
Copy link
Owner
jarun commented Mar 4, 2021

I added the check for selection file size 0. Please take a look.

@hankchiutw
Copy link
Author

@jarun With the patch, the file can be copied/moved as expected.
But the moved file is still listed in the first instance unless I invoke redrawing manually(e.g. switch folder and back)

jarun added a commit that referenced this issue Mar 4, 2021
@jarun
Fix regression in #864
8886f1c
@jarun
Copy link
Owner
jarun commented Mar 4, 2021 •
edited
Loading

That's because we block directory updates while selecting files. Otherwise it may be a bigger issue in the regular case where you are cherry-picking 10 files and suddenly a directory update happens and your view gets changed.

So please live with it.

@hankchiutw
Copy link
Author

I see. Thanks for your support!

KenJean pushed a commit to KenJean/nnn that referenced this issue Mar 19, 2021
@jarun
Fix jarun#864
7034a80
KenJean pushed a commit to KenJean/nnn that referenced this issue Mar 19, 2021
@jarun
Fix regression in jarun#864
52f0192
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jarun @hankchiutw @KlzXS 2AE0
0