Fix BulbDevice for non-bulb devices #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR updates BulbDevice so that turn_on()/turn_off() will work even when used on non-bulb devices by falling back to DP 1, tracks if status was attempted, and hardens capability mapping.
- Bump version to 1.17.1
- Replace obsolete retry attributes with a
tried_statusflag and modifyturn_onoffto detect a bulb once and default to DP 1 - Add a type check in
set_bulb_capabilitiesto ensuremappingis always a dict
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tinytuya/core/core.py | Bumped version_tuple to (1, 17, 1) |
| tinytuya/BulbDevice.py | Replaced old retry fields with tried_status, updated turn_onoff and added mapping type check |
| tests.py | Added tests for explicit bulb type and non-bulb fallback behavior |
Comments suppressed due to low confidence (3)
tinytuya/BulbDevice.py:406
- [nitpick] The docstring should be updated to note that when no switch DP is detected, this method now defaults to DP '1' for non-bulb devices.
def turn_onoff(self, on, switch=0, nowait=False):
tinytuya/BulbDevice.py:899
- [nitpick] Consider adding a unit test for
set_bulb_capabilitiesto verify that passing a non-dict (e.g.,None) correctly falls back to an empty mapping.
if not isinstance( mapping, dict ):
tinytuya/core/core.py:96
- [nitpick] Indentation appears inconsistent with surrounding top-level declarations; align this line to match the project style.
version_tuple = (1, 17, 1) # Major, Minor, Patch
|
View at: Thanks @uzlonewolf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people may use BulbDevice as a default even for non-bulb devices, and turn_on()/turn_off() should still work even in that case. See #572