Fix conflict with parameter named 'value' #39

guilhermearaujo · 2024-09-21T15:39:16Z

There is a conflict when a class has a parameter named value
Example:

@genq
class Example with _$Example {
  factory Example({required int value}) = _Example;
}

Generates:

class _$ExampleCopyWithImpl implements $ExampleCopyWith {
  final _$Example value;

  _$ExampleCopyWithImpl(this.value);

  @override
  Example call({
    Object? value = genq,
  }) {
    return Example(
      value: value == genq ? value.value : value as int,
    );                             ^^^^^
  }
}

Which results in the error:
example.genq.dart:xx:yy: Error: The getter 'value' isn't defined for the class 'Object?'

The fixed output should use __value instead:

class _$ExampleCopyWithImpl implements $ExampleCopyWith {
  final _$Example __value;

  _$ExampleCopyWithImpl(this.__value);

  @override
  Example call({
    Object? value = genq,
  }) {
    return Example(
      value: value == genq ? __value.value : value as int,
    );
  }
}

jankuss · 2024-09-22T22:44:42Z

Good catch, thank you for your contribution! This fix is included in the 0.5.1 release.

brew upgrade jankuss/genq/genq

Fix conflict with parameter named 'value'

5345f15

jankuss self-requested a review September 22, 2024 22:07

jankuss merged commit ca8cdfa into jankuss:main Sep 22, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix conflict with parameter named 'value' #39

Fix conflict with parameter named 'value' #39

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix conflict with parameter named 'value' #39

Fix conflict with parameter named 'value' #39

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!