8000 Fix overlapping statusbar by tkrajacic · Pull Request #2 · jakob/TableTool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix overlapping statusbar #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2016
Merged

Fix overlapping statusbar #2

merged 1 commit into from
Jun 13, 2016

Conversation

tkrajacic
Copy link
Contributor

Problem

Currently, when there are many rows in the CSV the statusbar overlaps the last two rows without the user being able to scroll down to see them.

Cause

The reason for this is that the scrollview has a bottom constraint to the splitview instead of its direct ancestor container.

Solution

This pull request fixes this problem by deleting the constraint to the splitview and adding a constraint to the custom container which is a direct ancestor to the scrollview.

Note:
The other changes to the xib are just from the fact that Xcode likes to modify misplaced views automatically sometimes. I have not acted on any of that intentionally.

@tkrajacic
Copy link
Contributor Author

Come to think of it, it might also be better to add the subview using
[self.splitView addArrangedSubview:statusBarFormatViewController.view];
instead of
[self.splitView addSubview:statusBarFormatViewController.view positioned:NSWindowAbove relativeTo:self.splitView];

I am actually not sure what the difference is, but since NSSplitView provides this method explicitly I'd use it.

If you agree I can add another commit to this PR doing this.

@jakob
Copy link
Owner
jakob commented Jun 13, 2016

Awesome! Thanks for catching this bug, and even more thanks for immediately fixing it too!

@jakob jakob merged commit f5cec86 into jakob:master Jun 13, 2016
@jakob
Copy link
Owner
jakob commented Jun 13, 2016 •
edited
Loading

addArrangedSubview: is only available on OS X 10.11 and later. It was probably introduced so that NSSplitView has the same programming interface as NSStackView.

@tkrajacic
Copy link
Contributor Author

Ah I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkrajacic @jakob
0