-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add exclusions support to cli #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Above is the error from JDK9 pipeline, how could I sovle ? |
@Stark-X We have a sanity check in our build for the size of the zip with all artifacts: https://github.com/jacoco/jacoco/blob/master/jacoco/pom.xml#L114 You may increase the upper limit. |
org.jacoco.report/pom.xml
Outdated
@@ -30,6 +30,11 @@ | |||
<groupId>${project.groupId}</groupId> | |||
<artifactId>org.jacoco.core</artifactId> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, we don't want to have that dependency outside the Maven plugin. Why should any user of our library get an dependeny on the Maven framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the exiting filtering in core we use our own class WildcardMatcher, maybe this works here.
before jdk 7, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test code?
It is. The JaCoCo agent runs with in the target application. And here we support Java 5 as a runtime (still many application in production out there using it). As the JaCoCo agent uses large parts of the JaCoCo core we maintain Java 5 compatibility for the overall code base. |
Add arg
--exclusions
to jacoco cli