-
Notifications
You must be signed in to change notification settings - Fork 15
Accepted: RFC for cell range syntax #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Just a minor thing: We currently allow relative positioning from the top/left but not from the bottom/right. This might be handy for cases where e.g. unusable metadata sits at the bottom instead of at the top. Thus, I suggest to introduce like Python a syntax to address this by negative values handling it like a ring structure. Not because I think it is good syntax, solely because I don't have a better idea.
|
Good point @georg-schwarz.
I think there is a mistake in your example, it should be Alternative proposal using numerical offsetsIn my opinion, the syntax you propose is not so easy to understand, especially when using it with column letters (e.g.
Syntactic sugar version for an entire row / column would be:
|
I think that syntax is very hard to read, I'd avoid including that until we have an actual problem. Especially with using -, I think it looks more like a range (A-1 looks like "A minus 1" to me, not "A to negative 1"). |
Yeah, my bad :)
Maybe a neutral sign indicating "enumeration from top/right" is better.. e.g.
I agree that we don't need to fully implement the RFC for the time being. But for the sake of the RFC it should be somehow discussed ;) |
Haha yeah, my point was I think we should talk about it and decide to not do it as part of the RFC with the reason that it adds to the complexity of syntax. |
@georg-schwarz would it be fine for you to propose and discuss the syntax for selecting cells at the end in a future RFC? I can add it to the drawbacks of this current RFC and create an issue so it's documented. |
RFC for the cell range syntax, extracted from #109.
This hopefully helps us to finalize the cell range syntax separately and afterwards concentrate on the remaining parts of the discussion.